@W-21332566 - Use getConnection instead of axios#398
Merged
iowillhoit merged 7 commits intomainfrom Mar 5, 2026
Merged
Conversation
ad-shreya
changed the title
manandey
approved these changes
Feb 24, 2026
iowillhoit
reviewed
Feb 25, 2026
iowillhoit
reviewed
Feb 26, 2026
Collaborator
|
Is this still used? I am seeing some old connection logic |
ad-shreya
force-pushed
the
ashreya/remove-axios
branch
from
efd009d to
047fb88
Compare
Collaborator
|
Looks like |
Collaborator
|
I am still seeing a few places that are using |
iowillhoit
reviewed
Mar 5, 2026
|
|
||
| try { | ||
| const result = await promoteWorkItems(input.usernameOrAlias, { workitems: prepared }); | ||
| const connection = await this.services.getOrgService().getConnection(input.usernameOrAlias); |
Collaborator
There was a problem hiding this comment.
Grabbing the connection twice in the same exec. You could define the top getConnection our of the try and then reuse it here
iowillhoit
reviewed
Mar 5, 2026
| workItemName: string | ||
| ): Promise<WorkItem | null | any> { | ||
| try { | ||
| const connection = await getConnection(username); |
Collaborator
There was a problem hiding this comment.
Now that this getConnection is removed, this function looks the same as fetchWorkItemByName below
Collaborator
|
It looks like the |
iowillhoit
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses getOrgService instead of axios.
Benefits of using getOrgService-
What issues does this PR fix or reference?
@W-21332566@